fix: use memoized fn in use-interval (#2029) #2070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@li-jia-nan could u make a review 😂 |
li-jia-nan
approved these changes
Mar 2, 2023
|
感觉命名可以再优化一下，cb 有点敷衍了 |
|
cb -> memoizedFn :) |
|
@li-jia-nan @liuyib done |
|
useTimeout 在 react devtools 中也有问题，顺便一起修了 |
liuyib
reviewed
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
#2029
💡 Background and solution
使用 useMemoizedFn 替换 useLatest 解决与 devtool 冲突的问题
详见 #728 (comment)
📝 Changelog
☑️ Self Check before Merge